[TypeChecker] Improve performance of key path expression inference #70148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esolved If key path type has bindings and is no longer delayed it means that it's fully resolved and ready to be bound (even though value type might not be resolved yet).
…ases If array literal type is not delayed and doesn't have any type variables associated with it, let's prefer it over a disjunction to facilitate type propagation through its `Element` type to element expressions. Resolves: rdar://118993030
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
hborla
approved these changes
Dec 1, 2023
|
@swift-ci please clean test macOS platform |
xedin
added a commit
to xedin/swift
that referenced
this pull request
Dec 4, 2023
Follow-up to swiftlang#70148 Just like with arrays it's advantageous to favor dictionary literals over disjunctions to bind the elements together and enable inference across elements and, as a consequence, type pruning. Resolves: rdar://119040159
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
Follow-up to swiftlang#70148 Just like with arrays it's advantageous to favor dictionary literals over disjunctions to bind the elements together and enable inference across elements and, as a consequence, type pruning. Resolves: rdar://119040159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding key path type as soon as capability is known helps to propagate
Valuetype to the context.Binding array literal type early helps to connect and propagate type information across its elements.
Resolves: rdar://118993030