Teach AST verifier about thrown error contexts #70160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AST verifier was only correctly extracting thrown error types from enclosing functions, without account for do...catch bodies. Switch it over to using ASTScope's lookup to find the innermost enclosing caught error context. Fixes a AST verifier error reported by Paul Cantrell
DougGregor
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
|
ARGH |
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AST verifier was only correctly extracting thrown error types from
enclosing functions, without account for do...catch bodies. Switch it
over to using ASTScope's lookup to find the innermost enclosing caught
error context.
Fixes a AST verifier error reported by Paul Cantrell