[ASTGen] Implement SequenceExpr generation #70168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
zoecarver,
CodaFi,
ahoppen,
bnbarham,
DougGregor,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
astgen-sequenceexpr
branch
4 times, most recently
from
a21d732 to
42d151f
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test Windows |
rintaro
force-pushed
the
astgen-sequenceexpr
branch
from
42d151f to
0c111ac
Compare
|
@swift-ci Please smoke test |
ahoppen
reviewed
Dec 4, 2023
| asLoc: asLoc, | ||
| type: type | ||
| ).asExpr | ||
| case let question? where question.text == "?": |
There was a problem hiding this comment.
I would prefer to check where question.tokenKind == .postfixQuestionMark instead of doing the string comparison. Similar below for ! which should check for .exclamationMark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
arrowExpr,assignmentExpr,binaryOperatorExpr,discardAssignmentExpr,postfixOperatorExpr,prefixOperatorExpr,sequenceExpr,typeExprunresolvedAsExpr,unresolvedIsExpr, andunresolvedTernaryExpr.