[5.10][Compile Time Constant Extraction] Extract from all macro expansions #70173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sions Extend constant extraction to extract: 1. members introduced by freestanding declaration macros and peer macros 2. from types introduced by peer macros Fix rdar://118948638
ApolloZhu
added
🍒 release cherry pick
|
@swift-ci please smoke test |
DougGregor
approved these changes
Dec 1, 2023
|
@swift-ci please test |
artemcm
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #70104
Explanation: visit struct expanded from peer macro and declarations' all members for compile time constant extraction. Note that the change is much simpler comparing to the main branch PR as extraction in 5.10 doesn't support extracting from extensions to types not defined in the extraction scope.
Scope: compile time constant extraction where source file uses some macro
Main Branch PR: #70104
Resolves: rdar://118948638
Risk: Low, additive change to compile time constant extraction only
Reviewed By: @DougGregor, @artemcm
Testing: added test-cases to the test suite