Skip to content

[CSBindings] Don't favor unresolved key path type over a conjunction #70175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Dec 2, 2023

If key path capability is not yet determined it cannot be favored over a conjunction because:

  1. There could be no other bindings and that would mean that key path would be selected even though it's not yet ready.
  2. A conjunction could be the source of type context for the key path.

Resolves: rdar://119055010

If key path capability is not yet determined it cannot be favored
over a conjunction because:

1. There could be no other bindings and that would mean that
   key path would be selected even though it's not yet ready.
2. A conjunction could be the source of type context for the key path.

Resolves: rdar://119055010
@xedin xedin requested a review from hborla as a code owner December 2, 2023 01:19
@xedin
Copy link
Contributor Author

xedin commented Dec 2, 2023

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Dec 2, 2023

@swift-ci please test source compatibility

@xedin
Copy link
Contributor Author

xedin commented Dec 2, 2023

@swift-ci please test Windows platform

@xedin xedin merged commit d54f03e into swiftlang:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant