[5.10] Fix tryRewriteToPartialApplyStack to handle undef #70177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rdar://117366370 callback_fn<tryRewriteToPartialApplyStack (cherry picked from commit 224c379)
|
@swift-ci test |
tbkka
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://117366370 callback_fn<tryRewriteToPartialApplyStack
(cherry picked from commit 224c379)
--- CCC ---
Explanation: ClosureLifetimeFixup bug. Here, insertDestroyOfCapturedArguments checks isTrivial with an 'undef' which always crashes because 'undef' doesn't have a function.
Scope: This is a regression in 5.10 but appears to only crash with invalid code.
Issue: rdar://117366370 Crash: callback_fn<tryRewriteToPartialApplyStack(swift::ConvertEscapeToNoEscapeInst*
Risk: Zero. Substitutes a condition that would always crash with an equivalent condition that will never crash.
PR to main: #70176
Testing: Added regression test to the test suite.
Reviewer: @meg-gupta