Sema: Break request cycle when building TypeRefinementContexts #70178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
a team,
hborla,
xedin and
tshortli
as code owners
This fixes a recent regression introduced in the changes to make TRC construction lazier in b33a71d. Calling VarDecl::hasInitialValue() can ask for attached property wrappers, which can trigger macro expansion. However, macro expansion can result in TRC construction, causing a cycle. Instead, just always build a lazy TRC for the initializer. It might not be needed, but it's safest to not ask anything of the VarDecl at all. Fixes rdar://118452948.
slavapestov
force-pushed
the
trc-cycle-rdar118452948
branch
from
03ed7ca to
d579a76
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a recent regression introduced in the changes to make TRC construction lazier in b33a71d.
Calling VarDecl::hasInitialValue() can ask for attached property wrappers, which can trigger macro expansion. However, macro expansion can result in TRC construction, causing a cycle.
Instead, just always build a lazy TRC for the initializer. It might not be needed, but it's safest to not ask anything of the VarDecl at all.
Fixes rdar://118452948.