[NCGenerics] Serialization for noncopyable generic types. #70180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
swiftlang/llvm-project#7842 |
kavon
force-pushed
the
noncopyable-serialization
branch
from
5eed9d8 to
f9f80fa
Compare
|
@swift-ci smoke test |
kavon
force-pushed
the
noncopyable-serialization
branch
6 times, most recently
from
c9c3b3f to
8712f11
Compare
|
@swift-ci smoke test |
kavon
force-pushed
the
noncopyable-serialization
branch
from
8712f11 to
04e5c4c
Compare
|
@swift-ci smoke test |
kavon
force-pushed
the
noncopyable-serialization
branch
from
04e5c4c to
6f9a641
Compare
kavon
requested review from
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
slavapestov
reviewed
Dec 12, 2023
slavapestov
reviewed
Dec 12, 2023
slavapestov
reviewed
Dec 12, 2023
slavapestov
reviewed
Dec 12, 2023
| @@ -6920,11 +6920,16 @@ DESERIALIZE_TYPE(GENERIC_TYPE_PARAM_TYPE)( | |||
|
|
|||
| Expected<Type> DESERIALIZE_TYPE(PROTOCOL_COMPOSITION_TYPE)( | |||
| ModuleFile &MF, SmallVectorImpl<uint64_t> &scratch, StringRef blobData) { | |||
| bool hasExplicitAnyObject; | |||
| bool hasExplicitAnyObject, hasInverseCopyable, hasInverseEscapable; | |||
There was a problem hiding this comment.
Maybe we should have an OptionSet for PCT flags at this point
kavon
force-pushed
the
noncopyable-serialization
branch
from
6f9a641 to
6f79d24
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
kavon
force-pushed
the
noncopyable-serialization
branch
from
6f79d24 to
027718b
Compare
|
@swift-ci please smoke test |
resolves rdar://118947007
We can't simply emit the desugared, expanded version of the requirements because there's no way to pretty-print the type `some ~Copyable` when the `~Copyable`'s get replaced with the absence of `Copyable`. We'd be left with just `some _` or need to invent a new top type so we can write `some Top`. Thus, it's best to simply reverse the expansion of default requirements when emitting a swiftinterface file.
kavon
force-pushed
the
noncopyable-serialization
branch
from
027718b to
bd13307
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux platform |
1 similar comment
|
@swift-ci please smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers serialization and deserialization of ~Copyable types when NoncopyableGenerics is enabled. This means that you can now write:
and emit Swift module containing that type, to be imported by another module.
resolves rdar://118947007&119531975