Skip to content

[Concurrency] Check the outermost parent source file when diagnosing Sendable conformances outside the defining source file. #70185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

hborla
Copy link
Member

@hborla hborla commented Dec 2, 2023

This allows macros to add a Sendable conformance when the macro is applied in the same source file as the primary declaration.

Resolves #68728

Sendable conformances outside the defining source file.

This allows macros to add a Sendable conformance when the macro is applied
in the same source file as the primary declaration.
@hborla
Copy link
Member Author

hborla commented Dec 2, 2023

@swift-ci please smoke test

@hborla hborla merged commit 8d22e48 into swiftlang:main Dec 2, 2023
@hborla hborla deleted the sendable-extension-macro branch December 2, 2023 23:03
@mansbernhardt
Copy link

@hborla Thanks for fixing this. Any chance this can go into the 5.10 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The extension macro designed to add Sendable conformance generates an unexpected warning
2 participants