[SE-0408] Enable nested iteration #70196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simanerush
requested review from
hborla,
xedin,
ahoppen,
bnbarham,
rintaro,
hamishknight and
slavapestov
as code owners
13 tasks
|
Thanks for also adding |
simanerush
force-pushed
the
nested-pack-iteration
branch
from
eff5640 to
cfe918f
Compare
xedin
reviewed
Dec 18, 2023
simanerush
force-pushed
the
nested-pack-iteration
branch
from
cfe918f to
5a74d5c
Compare
|
@swift-ci please smoke test |
xedin
approved these changes
Jan 24, 2024
simanerush
force-pushed
the
nested-pack-iteration
branch
from
5a74d5c to
9b6fa6c
Compare
xedin
reviewed
Jan 27, 2024
|
Feel free to land this! |
… with`for`-`in` loops over parameter packs to apply in `getPackElementEnvironment`.
simanerush
force-pushed
the
nested-pack-iteration
branch
from
9b6fa6c to
0b167b5
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables nested iteration for SE-0408
Changes:
getPackElementEnvironmentmapElementTypeIntoPackContext, use the interface type to obtain the correct depth.