[region-isolation] Fix two issues around setters. #70197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://119113959
…y mark their operands as being actor derived. I did this by abstracting the representative value of an equivalence class into two cases: the normal case of actually having a value and a second case which is used only to inject into a region an actor derived value. rdar://119113563
|
@swift-ci smoke test |
|
@swift-ci build toolchain |
gottesmm
commented
Dec 4, 2023
| getActorIntroducingRepresentative(SILInstruction *introducingInst) const { | ||
| auto *self = const_cast<PartitionOpTranslator *>(this); | ||
| auto iter = self->equivalenceClassValuesToState.try_emplace( | ||
| introducingInst, |
There was a problem hiding this comment.
In a subsequent commit, I am going to add an assert here that introducingInst doesn't have any results.
slavapestov
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit ensures that we properly handle treating things assigned into fields of a final actor as being in the actor's region.
rdar://119113563
The second commit ensures the same thing for non-final setters. In truth it is actually fixing a larger issue around functions with an isolated self and no results. Before this commit, we relied on such a function having a result to ensure that the regions of the operands had an actor derived element (the result of the operation) within it. Of course if there isn't a result... that can't happen. So I introduced a "fake" value represented via the specific apply instruction that is injected into the region to ensure that we get the semantics we are searching for.
rdar://119113959