[ASTGen] Start using 'TokenSyntax.rawText' #70201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
approved these changes
Dec 4, 2023
|
swiftlang/swift-syntax#2383 |
bnbarham
approved these changes
Dec 4, 2023
ahoppen
reviewed
Dec 4, 2023
`TokenSyntax.text` causes intiation of heap allocated `Swift.String` for each access. `TokenSyntax.rawText` is faster than that because it's just a reference to the pre-allocated buffer. Also, converting to `BridgedString` is simplar, and guaranteed to be free, unlike bridging via `String.withUTF8(_:)`
rintaro
force-pushed
the
astgen-syntaxtext
branch
from
4e6e44b to
e1f0089
Compare
|
swiftlang/swift-syntax#2383 |
Maybe, we should factor out the portion of it. i.e. not relying on |
|
I agree that some design work would need to be done here. That’s why we haven’t exposed these enums as public API yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokenSyntax.textcauses instantiation of a heap allocatedSwift.Stringfor each access.TokenSyntax.rawTextis faster than that because it's just a reference to a slice of the pre-allocated buffer. Also, converting toBridgedStringis simplar, and guaranteed to be free, unlike bridging viaString.withUTF8(_:)