[cmake] Fix LLDB for ASTGen #70204
Merged
[cmake] Fix LLDB for ASTGen #70204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
ahoppen,
bnbarham,
rintaro and
eeckstein
as code owners
hamishknight
force-pushed
the
ast-for-lldb
branch
2 times, most recently
from
18f0f82 to
de2b8a6
Compare
hamishknight
commented
Dec 4, 2023
SwiftCompilerSources/CMakeLists.txt
Outdated
| @@ -231,6 +232,16 @@ function(add_swift_compiler_modules_library name) | |||
| add_library(${name} STATIC ${all_obj_files}) | |||
| add_dependencies(${name} ${all_module_targets}) | |||
| set_target_properties(${name} PROPERTIES LINKER_LANGUAGE CXX) | |||
|
|
|||
| if(SWIFT_HOST_VARIANT_SDK IN_LIST SWIFT_DARWIN_PLATFORMS) | |||
There was a problem hiding this comment.
Not sure if there's a better check that can be used here to test for the linker being able to support -add_ast_path, this is the check that guarded the previous logic though.
hamishknight
force-pushed
the
ast-for-lldb
branch
from
de2b8a6 to
6384044
Compare
Add the swiftmodule paths for ASTGen via `-add_ast_path` to the public linker flags such that downstream linking picks them up, allowing LLDB to load them when debugging. Also switch SwiftCompilerModules to using public linker flags instead of adding the linker flags in `_add_swift_runtime_link_flags`.
hamishknight
force-pushed
the
ast-for-lldb
branch
from
6384044 to
73c6dcb
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the swiftmodule paths for ASTGen via
-add_ast_pathto the public linker flags such that downstream linking picks them up, allowing LLDB to load them when debugging. Also switch SwiftCompilerModules to using public linker flags instead of adding the linker flags in_add_swift_runtime_link_flags.