[region-isolation] Change PartitionOpEvaluator to use CRTP #70205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtition. I left them as friends since that was in the original code. There isn't a reason to do this and break the encapsulation of Partition. I just added reasonable helpers that give PartitionOpEvaluator all of the functionality it needs.
…:function callbacks. Just a fixup requested by reviewers of incoming code that I wanted to do in a follow on commit.
|
@swift-ci smoke test |
xedin
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@slavapestov and I talked about doing this in the previous set of commits, but I wanted to do it in a separate commit by itself. This is that commit.