[Dependency Scanning] Remove/move mutable state from parallel scanner workers #70211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
hborla,
slavapestov,
xedin,
zoecarver,
hyp and
egorzhdan
as code owners
…ion' from the scanner. It overlays a non-thread-safe filesystem on shared compilation instances and is no longer valid with parallel scanning.
artemcm
force-pushed
the
ParallelScanFixes
branch
from
5a9ea05 to
9986150
Compare
|
@swift-ci smoke test |
artemcm
force-pushed
the
ParallelScanFixes
branch
from
9986150 to
87e7c3a
Compare
|
@swift-ci smoke test |
artemcm
force-pushed
the
ParallelScanFixes
branch
from
87e7c3a to
5281a74
Compare
…ier' out of the individual scanning workers up into the parent scanner. This operation mutates the scanner ASTContext by potentially adding new identifiers to it and is therefore not thread-safe.
artemcm
force-pushed
the
ParallelScanFixes
branch
from
5281a74 to
674dfb3
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifierout of the individual scanning workers up into the parent scanner. This operation mutates the scannerASTContextby potentially adding new identifiers to it and is therefore not thread-safe.overlaySharedFilesystemCacheForCompilationfrom the scanner. It overlays a non-thread-safe filesystem on shared compilation instances and is no longer valid with parallel scanning.