[CSBinding] Infer key path root bindings transitively through context… #70212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test Windows platform |
…tual root variable
Since generic arguments have to match exactly the inference could
be extended to transfer bindings through contextual root types if
they are sufficiently resolved (not delayed).
For example if key path expression is passed as an argument to
a parameter like `WritableKeyPath<$Root, $Value>` and `$Root`
is not yet bound but has a binding set of `{String}` its bindings
are transferable over to resolve the key path which would be
ultimately bound to the contextual type.
…djacent vars Binding inference through a contextual root variable should include marking contextual root and all of its adjacent variables as adjacent to a key path root variable as well otherwise transitively inferred bindings are ranked incorrectly.
This makes sure that we never run into infinite recursion situations with transitive bindings that could have been aseembled and not properly checked.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test Linux platform |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
2 similar comments
|
@swift-ci please test source compatibility |
|
@swift-ci please test source compatibility |
|
Source compatibility suite is having unrelated issues, I'm just going to land this since it passed before without the last commit which shouldn't have any effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ual root variable
Since generic arguments have to match exactly the inference could
be extended to transfer bindings through contextual root types if they
are sufficiently resolved (not delayed).
For example if key path expression is passed as an argument to a parameter
like
WritableKeyPath<$Root, $Value>and$Rootis not yet bound but hasa binding set of
{String}its bindings are transferable over to resolve thekey path which would be ultimately bound to the contextual type.
Resolves: rdar://102384255