[test] Add dependency to the embedded-stdlib #70215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
kubamracek
approved these changes
Dec 5, 2023
|
Linux: failed because the node restarted? |
When not building `all`, like the `build-script` does in CI, the tests did not have a dependency on `embedded-stdlib`, and those tests will fail to pass if one was using CMake/Ninja to execute the tests after something like `ninja clean`. The dependency is added if the embedded stdlib is being built.
drodriguez
force-pushed
the
test-embedded-dependency
branch
from
a220c2c to
5ae7d43
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
When not building `all`, like the `build-script` does in CI, the tests did not have a dependency on `embedded-stdlib`, and those tests will fail to pass if one was using CMake/Ninja to execute the tests after something like `ninja clean`. The dependency is added if the embedded stdlib is being built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not building
all, like thebuild-scriptdoes in CI, the tests did not have a dependency onembedded-stdlib, and those tests will fail to pass if one was using CMake/Ninja to execute the tests after something likeninja clean.The dependency is added if the embedded stdlib is being built.