Skip to content

CMake: allow to build embedded stdlib in a standalone preset #70238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Dec 5, 2023

This would be needed to support Apple internal configurations.

Addresses rdar://119192035

This would be needed to support Apple internal configurations.

Addresses rdar://119192035
@edymtt edymtt requested a review from a team as a code owner December 5, 2023 17:52
@edymtt
Copy link
Contributor Author

edymtt commented Dec 5, 2023

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Dec 5, 2023

@swift-ci Please test stdlib with toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Dec 5, 2023

@swift-ci Please Build Toolchain

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting this to an option is a great idea!

@edymtt
Copy link
Contributor Author

edymtt commented Dec 5, 2023

@swift-ci Please test stdlib with toolchain

@edymtt
Copy link
Contributor Author

edymtt commented Dec 6, 2023

Double checked that in the build of stdlib with toolchain the embedded stdlib is not built;
and that in the toolchain presets for macOS and Linux the embedded stdlib is present in the generated tarballs.

@edymtt edymtt merged commit 4ab800e into swiftlang:main Dec 6, 2023
@edymtt edymtt deleted the edymtt/allow-embedded-stdlib-to-be-built-standalone branch December 6, 2023 23:38
Catfish-Man pushed a commit to Catfish-Man/swift that referenced this pull request Jan 19, 2024
…ng#70238)

This would be needed to support Apple internal configurations.

Addresses rdar://119192035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants