[stdlib] BitwiseCopyable loadUnaligned overloads. #70248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
rdar96956089
branch
from
a46d81d to
dbc63e7
Compare
|
@swift-ci please test |
|
I like this approach. The standard library team should review to be sure I'm not missing some problem. |
glessard
reviewed
Dec 5, 2023
| @@ -473,8 +483,6 @@ public struct UnsafeRawPointer: _Pointer { | |||
| ) | |||
| return temporary.pointee | |||
| } | |||
| //FIXME: reimplement with `loadRaw` when supported in SIL (rdar://96956089) | |||
| // e.g. Builtin.loadRaw((self + offset)._rawValue) | |||
| } | |||
There was a problem hiding this comment.
Can Builtin.loadRaw be used for the version that doesn't have the generic constraint?
There was a problem hiding this comment.
Unfortunately no--we need to generate a direct call to memcpy rather than to a value witness; the compiler needs to know the type is BitwiseCopyable in order to know doing so is correct.
If an archetype conforms to the protocol, use the new TypeInfo. This allows clients to use code in the stdlib that's built with BitwiseCopyable.
The new overloads will make use the new BitwiseCopyableArchetypeTypeInfo to avoid the extra copy that is currently done.
nate-chandler
force-pushed
the
rdar96956089
branch
from
dbc63e7 to
b7f5171
Compare
|
@swift-ci please test |
|
@swift-ci please test linux platform |
1 similar comment
|
@swift-ci please test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new overloads will make use of the new
BitwiseCopyableArchetypeTypeInfoto avoid the extra copy that is currently done.