[Rename] Collection of improvements to make syntactic rename easier to read #70255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
rintaro,
hamishknight,
zoecarver and
CodaFi
as code owners
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Dec 6, 2023
ahoppen
force-pushed
the
ahoppen/rename-refactoring
branch
from
c004f5c to
58ff819
Compare
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Dec 6, 2023
ahoppen
force-pushed
the
ahoppen/rename-refactoring
branch
from
58ff819 to
3e5a772
Compare
|
@swift-ci Please smoke test |
Refactor `addSyntacticRenameRanges`, adding comments to make it easier to follow and remove its dependency on the `IsFunctionLike` parameter in `RenameLoc`.
Remove unnecessary `ArrayRef` wrapping and introduce a struct instead of a `std::pair`.
It’s easier to understand the code if we don’t have these two nearly, but not quite, identical types.
ahoppen
force-pushed
the
ahoppen/rename-refactoring
branch
from
3e5a772 to
d53e1b9
Compare
|
@swift-ci Please smoke test |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of four independent refactoring that simplify syntactic rename. Should be reviewable commit by commit.