Skip to content

[Concurrency] Downgrade missing await errors to warnings when referencing @preconcurrency declarations. #70261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hborla
Copy link
Member

@hborla hborla commented Dec 6, 2023

Otherwise, libraries cannot isolate existing APIs using @preconcurrency without potentially breaking clients with effects checker errors.

Resolves rdar://116209687

@hborla
Copy link
Member Author

hborla commented Dec 6, 2023

@swift-ci please smoke test

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to help adoption without breaking folks. LGTM 👍

@hborla
Copy link
Member Author

hborla commented Dec 6, 2023

@swift-ci please smoke test Linux

@hborla hborla merged commit 944b023 into swiftlang:main Dec 6, 2023
@hborla hborla deleted the downgrade-preconcurrency-effect-errors branch December 6, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants