Skip to content

Add support for _resultDependsOn #70263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

meg-gupta
Copy link
Contributor

No description provided.

@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/swift-syntax#2386

@swift-ci Please test

@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/swift-syntax#2386

@swift-ci Please test linux platform

@@ -1,4 +1,4 @@
// RUN: %target-typecheck-verify-swift -enable-builtin-module -enable-experimental-feature NonEscapableTypes
// RUN: %target-typecheck-verify-swift -enable-builtin-module -enable-experimental-feature NonEscapableTypes -disable-experimental-parser-round-trip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn’t disable the new parser in these test cases. The new parser should support parsing of this source file as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rdar://118125715 needs to be fixed before I can enable the new parser for this test.

Copy link
Contributor Author

@meg-gupta meg-gupta Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swift-syntax PR has a test for cases that are supported with the new parser - swiftlang/swift-syntax#2386

These attributes are used to establish lifetime dependence between
argument and the result.

Add them under NonEscapableTypes experimental feature
@meg-gupta
Copy link
Contributor Author

Merge conflict in ModuleFormat.h

Testing again

@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/swift-syntax#2386

@swift-ci Please smoke test

1 similar comment
@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/swift-syntax#2386

@swift-ci Please smoke test

@meg-gupta meg-gupta merged commit 9a4bb73 into swiftlang:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants