Use interface types when checking #keyPath.

[jrose-apple]

This avoids a crash when the path refers to a property in another Swift module.

SR-3714

[jrose-apple]

@swift-ci Please test

[jrose-apple]

@slavapestov, is there a good way to find out if we have more of these mistakes?

[swift-ci]

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 2318d79771ed70e9b9577818ea5673a9c709972c
Test requested by - @jrose-apple

[jrose-apple]

@swift-ci Please test

[swift-ci]

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 2318d79771ed70e9b9577818ea5673a9c709972c
Test requested by - @jrose-apple

[swift-ci]

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 2318d79771ed70e9b9577818ea5673a9c709972c
Test requested by - @jrose-apple

[DougGregor]

Take away VarDecl::getType() ;)

[DougGregor]

(this LGTM, by the way)

[jrose-apple]

This failed on a mangling test that (IIRC) is failing elsewhere; unfortunately the bots are now being upgraded.

[slavapestov]

@jrose-apple Add assert(getDeclContext()->isLocalContext()) would shake out cases where we call getType() on a property of a type, but only test the case where the property is defined in the same module.

Or as Doug said, scrap this whole thing altogether, maybe add a LocalVarDecl subclass of VarDecl and move getType() there.

[jrose-apple]

@swift-ci Please test macOS

[swift-ci]

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - a06bc15
Test requested by - @jrose-apple

[jrose-apple]

Jenkins Java error, but the testing did actually finish, as evidenced by the smoke test label being fine. Merging.