Skip to content

[5.10][Test] Fix integer overflow in layout_string_witnesses_dynamic.swift … #70291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2023
Merged

[5.10][Test] Fix integer overflow in layout_string_witnesses_dynamic.swift … #70291

merged 1 commit into from
Dec 7, 2023

Conversation

drexin
Copy link
Contributor

@drexin drexin commented Dec 7, 2023

…on 32 bit targets

Cherry-pick of: #70290

  • Explanation: A test used an Int, when it should have been Int64, which caused an overflow on 32 bit targets
  • Issue: rdar://119268608
  • Risk: Low. Only fixes a test.
  • Reviewer: @beccadax

@drexin drexin added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.10 labels Dec 7, 2023
@drexin drexin requested a review from a team as a code owner December 7, 2023 07:10
@drexin
Copy link
Contributor Author

drexin commented Dec 7, 2023

@swift-ci test

@drexin drexin requested a review from tbkka December 7, 2023 07:11
@drexin drexin merged commit 0830d82 into swiftlang:release/5.10 Dec 7, 2023
@drexin drexin deleted the wip-119268608-5.10 branch December 7, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drexin @tbkka