[ASTGen] TokenSyntax.keyworkKind to directly get Keyword kind #70292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
requested review from
hamishknight
and removed request for
CodaFi and
zoecarver
rintaro
commented
Dec 7, 2023
Comment on lines
+432
to
+435
| switch keyword { | ||
| case .none?: self = .none | ||
| case .left?: self = .left | ||
| case .right?: self = .right |
There was a problem hiding this comment.
Just .none tries to match against Optional<Keyword>.none
rintaro
force-pushed
the
astgen-keywordkind
branch
2 times, most recently
from
d1c1564 to
02f015a
Compare
This should be faster than e.g. `token.tokenKind == .keyword(.true)`.
rintaro
force-pushed
the
astgen-keywordkind
branch
from
02f015a to
a12113a
Compare
hamishknight
approved these changes
Dec 7, 2023
|
@swift-ci Please smoke test |
AnthonyLatsis
approved these changes
Dec 7, 2023
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be faster than e.g.
token.tokenKind == .keyword(.true).