Skip to content

Add DirectX WinSDK modulemap changes from main #70295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

STREGA
Copy link
Contributor

@STREGA STREGA commented Dec 7, 2023

Adds the following 2 pull requests already merged into main.

Fix incorrect library name
#68888

Platform: remove cplusplus requirement on XAudio29
#70195

@STREGA STREGA requested a review from a team as a code owner December 7, 2023 13:12
@STREGA
Copy link
Contributor Author

STREGA commented Dec 7, 2023

@compnerd Would like to get these into 5.10. Not entirely sure if this is the right way to go about it.

@compnerd
Copy link
Member

compnerd commented Dec 7, 2023

I would prefer that we cherry-pick the exact changes rather than re-creating them. I do agree with this though.

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@DougGregor
Copy link
Member

@swift-ci please test

@DougGregor DougGregor enabled auto-merge December 7, 2023 18:25
@DougGregor DougGregor merged commit 3a7676c into swiftlang:release/5.10 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants