Skip to content

[Test] Disable some runtime tests in back deployment testing. #70302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Dec 7, 2023

These tests are testing changes that aren't present in older runtimes:

test/stdlib/SwiftValueNSObject.swift
test/stdlib/SwiftObjectNSObject.swift
test/stdlib/BridgeEquatableToObjC.swift

And this test looks for some wording that's different on older runtimes. This one already does availability checks, so we change the requirements to SwiftStdlib 5.11:

test/Casting/CastTraps.swift.gyb

rdar://116339747

These tests are testing changes that aren't present in older runtimes:

test/stdlib/SwiftValueNSObject.swift
test/stdlib/SwiftObjectNSObject.swift
test/stdlib/BridgeEquatableToObjC.swift

And this test looks for some wording that's different on older runtimes. This one already does availability checks, so we change the requirements to SwiftStdlib 5.11:

test/Casting/CastTraps.swift.gyb
@mikeash mikeash requested a review from tbkka December 7, 2023 18:01
@mikeash mikeash requested a review from a team as a code owner December 7, 2023 18:01
@mikeash
Copy link
Contributor Author

mikeash commented Dec 7, 2023

@tbkka Just a heads up, these are tests you recently wrote or modified.

@mikeash
Copy link
Contributor Author

mikeash commented Dec 7, 2023

@swift-ci please smoke test

Copy link
Contributor

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mikeash mikeash enabled auto-merge December 7, 2023 18:36
@mikeash mikeash merged commit f67ec2f into swiftlang:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants