[embedded] Implement non-allocating embedded Swift mode, under -no-allocations flag #70314
Conversation
kubamracek
requested review from
tshortli,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
kubamracek
force-pushed
the
embedded-no-alloc
branch
from
d4ada46 to
27026c8
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
| if (getModule()->getOptions().EmbeddedSwift) { | ||
| for (SILFunction &function : *module) { | ||
| // Don't check constructors and destructors directly, they will be | ||
| // checked if called from other functions, with better source loc info. |
There was a problem hiding this comment.
Not all constructors and destructors are directly called. For example, class destructors are implicitly called from destroy_value instructions.
Excluding them here means that they are potentially not checked at all.
There was a problem hiding this comment.
Hm, good point. What if instead of not checking them, I only changed the order in which we go over the SILFunctions, so that it's something like (1) public/external functions first, (2) vtable members without constructors/destructors, (3) constructors/destructors?
The motivation is strictly to get better diagnostics with better "called from here" information, I don't want to skip any checks.
There was a problem hiding this comment.
I only changed the order in which we go over the SILFunctions
Sounds good!
kubamracek
force-pushed
the
embedded-no-alloc
branch
from
1a20fe1 to
2739aeb
Compare
…gnostics when diagnosing embedded Swift restrictions
|
@swift-ci please test |
|
@swift-ci please test |
This PR: