[Sema] Correctly re-contextualize if/switch exprs in lazy vars
#70319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
slavapestov and
xedin
as code owners
With `if`/`switch` expressions, we may now have local bindings within lazy initializers, and therefore need to ensure we correctly re-contextualize them. Adjust the walker to set the DeclContext for all decls it encounters, and make sure it handles some cases that the ASTWalker does not currently visit. rdar://119158202
hamishknight
force-pushed
the
context-switch
branch
from
0b766ca to
29dac43
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
approved these changes
Dec 12, 2023
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
if/switchexpressions, we may now have local bindings within lazy initializers, and therefore need to ensure we correctly re-contextualize them. Adjust the walker to set the DeclContext for all decls it encounters, and make sure it handles some cases that the ASTWalker does not currently visit.rdar://119158202