[IRGen] Add getEnumTag and injectEnumTag builtins #70327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nate-chandler
approved these changes
Dec 8, 2023
| @@ -1968,6 +1968,26 @@ static ValueDecl *getPackLength(ASTContext &ctx, Identifier id) { | |||
| return builder.build(id); | |||
| } | |||
|
|
|||
| static ValueDecl *getGetEnumTag(ASTContext &ctx, Identifier id) { | |||
| BuiltinFunctionBuilder builder(ctx, /* genericParamCount */ 1); | |||
There was a problem hiding this comment.
Would be nice to use the getBuiltinFunction infrastructure here.
|
@swift-ci please test |
Azoy
force-pushed
the
inject-get-enum-tag-builtins
branch
from
4f8dc15 to
0ed4a19
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux |
1 similar comment
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 2 new builtins, one that calls the getEnumTag vwt function on a generic type and another that injects the given tag into some generic value. These are unsafe operations that assume the value passed in as
Tis an enum type.