[ASTGen] BridgedXXXTypeRepr_createParsed return the sub type if possible #70334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just for the consistensy with other BridgedXXX_createParsed().
rintaro
requested review from
zoecarver,
CodaFi,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
rintaro
requested review from
bnbarham,
ahoppen and
hamishknight
and removed request for
xedin,
slavapestov,
CodaFi,
hborla and
zoecarver
hamishknight
approved these changes
Dec 9, 2023
| base: type, | ||
| consumingAttributes: typeAttributes | ||
| ) | ||
| if (!typeAttributes.isEmpty) { |
There was a problem hiding this comment.
Suggested change
| if (!typeAttributes.isEmpty) { | |
| if !typeAttributes.isEmpty { |
ahoppen
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for the consistency with other
BridgedXXX_createParsed().