[cxx-interop] Allow imported subscript to have generic parameters. #70348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
requested review from
zoecarver,
hyp,
egorzhdan,
slavapestov and
xedin
as code owners
|
Neat! Thank you for fixing this🤩 |
hborla
force-pushed
the
cxx-generic-subscript
branch
from
f6b42d4 to
450e59c
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscripts imported from C++ can have generic parameter lists, but the Clang Importer was assuming that imported subscripts always have a null generic parameter list. Propagate generic parameters from the getter in
SwiftDeclSynthesizer.Thanks to @simanerush for adding the ASTVerifier change that surfaced this bug!
Resolves rdar://119406160, #70328