Skip to content

[Debug] Conditional _DebugDescription macro declaration #70351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

kastiglione
Copy link
Contributor

@kastiglione kastiglione commented Dec 9, 2023

Make _DebugDescription macro conditional upon macro availability in the build.

The Macros feature is based on the value of SWIFT_BUILD_SWIFT_SYNTAX.

See #69626 (comment)

@kastiglione kastiglione requested a review from a team as a code owner December 9, 2023 04:46
@kastiglione
Copy link
Contributor Author

@swift-ci test

@kastiglione
Copy link
Contributor Author

@swift-ci test linux

@kastiglione kastiglione changed the title [Debug] Conditional _DebugDescription declaration [Debug] Conditional _DebugDescription macro declaration Dec 11, 2023
Copy link
Contributor

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe comment that some targets build a stdlib without macros?
Would there a way to gracefully degrade code that uses the macro on a platform that doesn't have macros? I assume not...

@kastiglione
Copy link
Contributor Author

Would there a way to gracefully degrade code that uses the macro on a platform that doesn't have macros? I assume not...

I'm not aware of any way to do that. I haven't noticed any other code doing anything like that.

@kastiglione
Copy link
Contributor Author

@swift-ci test

@kastiglione
Copy link
Contributor Author

@swift-ci smoke test

@kastiglione
Copy link
Contributor Author

@swift-ci smoke test

@kastiglione kastiglione merged commit a56c89f into main Dec 12, 2023
@kastiglione kastiglione deleted the dl/Debug-Conditional-_DebugDescription-declaration branch December 12, 2023 23:19
Catfish-Man pushed a commit to Catfish-Man/swift that referenced this pull request Jan 19, 2024
)

Make `_DebugDescription` macro conditional upon macro availability in the build.

The `Macros` feature is based on the value of `SWIFT_BUILD_SWIFT_SYNTAX`.

See swiftlang#69626 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants