AST: DeclExportabilityVisitor fixes #70358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
changed the title
tshortli
force-pushed
the
exportability-fixes
branch
from
663e122 to
1297979
Compare
Instances of `MacroExpansionDecl` may be found in the AST when declarations are expanded from freestanding declaration macros and therefore exportability computations must be prepared to handle them. Resolves rdar://119449439
tshortli
force-pushed
the
exportability-fixes
branch
from
1297979 to
3c68c20
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeclExportabilityVisitorwasn't handling macro expansion, pound diagnostics, and top-level code declarations which lead to crashes when emitting SIL with-experimental-skip-non-exportable-declsfor some modules.Resolves rdar://119449439