[Runtime] Use malloc_type_posix_memalign(). #70366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use `malloc_type_aligned_alloc()` because `aligned_alloc()` requires that `size` be a multiple of `alignment`, which isn't something we expect here. rdar://119137861
|
@swift-ci Please smoke test |
mikeash
approved these changes
Dec 11, 2023
|
@swift-ci Please smoke test macOS platform |
We should have some tests for the heap functions. Note that these wouldn't have caught the problem that we fixed in the previous commit, because the conditions under which they run presently mean that the problematic code wouldn't have been active. They will *eventually* test that code, however. rdar://119137861
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test linux platform |
|
@swift-ci Please smoke test Linux platform |
1 similar comment
|
@swift-ci Please smoke test Linux platform |
|
This looks fine to me, but I'm not a swift reviewer so I won't click any of the review buttons :D |
rapidsna
approved these changes
Dec 12, 2023
|
@swift-ci Please smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use
malloc_type_aligned_alloc()becausealigned_alloc()requires thatsizebe a multiple ofalignment, which isn't something we expect here.rdar://119137861