[ASTGen] Implement Patterns #70387
Merged
[ASTGen] Implement Patterns #70387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
zoecarver,
CodaFi,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
rintaro
requested review from
bnbarham,
ahoppen and
hamishknight
and removed request for
xedin,
slavapestov,
CodaFi,
hborla and
zoecarver
ahoppen
approved these changes
Dec 11, 2023
bnbarham
reviewed
Dec 11, 2023
| } | ||
|
|
||
| func generate(tuplePattern node: TuplePatternSyntax) -> BridgedPattern { | ||
| if node.elements.count == 1 && node.elements.first!.label == nil { |
There was a problem hiding this comment.
Suggested change
| if node.elements.count == 1 && node.elements.first!.label == nil { | |
| if node.elements.count == 1, let firstElement = node.elements.first, firstElement.label == nil { |
And then firstElement can be re-used further down (firstElement.pattern).
Comment on lines
+1147
to
+1149
| BridgedIdentifier Label; | ||
| BridgedSourceLoc LabelLoc; | ||
| BridgedPattern ThePattern; |
There was a problem hiding this comment.
We are inconsistent. Let's clean them up later.
hamishknight
approved these changes
Dec 11, 2023
Except `MissingPatternSyntax`
rintaro
force-pushed
the
astgen-pattern
branch
from
4530eef to
eb46b6f
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
1 similar comment
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expect
MissingPatternSyntax.