[region-isolation] Add the ability to write SIL tests for actor isolation #70394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let me add functionality into the SILParser into other files. The main file is already very large.
…g at the SIL level on apply, begin_apply, try_apply. Some notes: This is not emitted by SILGen. This is just intended to be used so I can write SIL test cases for transfer non sendable. I did this by adding an ActorIsolationCrossing field to all FullApplySites rather than adding it into the type system on a callee. The reason that this makes sense from a modeling perspective is that an actor isolation crossing is a caller concept since it is describing a difference in between the caller's and callee's isolation. As a bonus it makes this a less viral change. For simplicity, I made it so that the isolation is represented as an optional modifier on the instructions: apply [callee_isolation=XXXX] [caller_isolation=XXXX] where XXXX is a printed representation of the actor isolation. When neither callee or caller isolation is specified then the ApplyIsolationCrossing is std::nullopt. If only one is specified, we make the other one ActorIsolation::Unspecified. This required me to move ActorIsolationCrossing from AST/Expr.h -> AST/ActorIsolation.h to work around compilation issues... Arguably that is where it should exist anyways so it made sense. rdar://118521597
gottesmm
requested review from
ktoso,
kavon,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
gottesmm
force-pushed
the
pr-f328e7893b344f5252d43a4358baf49fb4589abe
branch
from
65bf927 to
a43e5e6
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test linux platform |
slavapestov
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this by adding the ability to specify callee/caller isolation on apply, begin_apply, try_apply. The reason why this is needed is currently we grab the isolation from the applyexpr attached to a SILLocation. If we don't have an AST though that doesn't work of course. Instead, we can use these optional markers so we can at least write tests.
rdar://118521597