[Typed throws] Cleanups for the caught error type computation #70397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equest These two requests are effectively doing the same thing to two different cases within CatchNode. Unify the requests into a single request, ExplicitCaughtTypeRequest, which operates on a CatchNode. This also moves the logic for closures with explicitly-specified throws clauses into the same request, taking it out of the constraint system.
…losures Teach the constraint system to use the same primitives as elsewhere to determine the type context for a `throw` statement and the caught error type within a `do..catch` statement. This makes explicitly-specified `throws` work on `do..catch` that occurs in closures. Cleans up some redundant computations for caught error types.
DougGregor
requested review from
hborla,
xedin,
AnthonyLatsis,
slavapestov,
zoecarver,
hyp and
egorzhdan
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify
ThrownTypeRequestandDoCatchExplicitThrownTypeRequest. These two requests are effectively doing the same thing to two different cases withinCatchNode. Unify the requests into a singlerequest,
ExplicitCaughtTypeRequest, which operates on a CatchNode.This also moves the logic for closures with explicitly-specified throws
clauses into the same request, taking it out of the constraint system.
Also unify some of the computation of the "caught" type for a
CatchNode, fixing an issue whereexplicitly-specified types on a
do..catchweren't getting used within a closure.