-
Notifications
You must be signed in to change notification settings - Fork 10.5k
SwiftCompilerSources support for OSSA and lifetime dependence #70460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e842df6
Add Swift SIL instructions needed by AddressUseVisitor
atrick f211b58
Add OperandOwnership.endsLifetime
atrick 5b777bc
Add Stack.Marker and Stack.Segment utilities.
atrick 2c5010e
Add SingleInlineArray utility.
atrick 065cab9
ForwardingUtils comment formatting.
atrick 6d6b05e
ForwardingUtils.swift cleanup. Make the API easier to extend.
atrick 1a3714c
Add BorrowUtils: OSSA infrastructure for borrow scopes.
atrick e573c8c
BorrowIntroducer unit tests
atrick b04d32b
SwiftCompilerSources: add UseList ignoreTypeDependence
atrick 2c08a16
Add OwnershipLiveness.swift. Core OSSA APIs.
atrick 94d1b39
Ownership liveness in Swift unit tests.
atrick 66938f4
[SIL] bridge MoveValue and BeginBorrow .isFromVarDecl [WIP]
atrick 446c56a
SwiftCompilerSources: add VarDecl.sourceLoc
atrick f4b7d0b
Add LifetimeDependence utilities
atrick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is effectively an index. So let's call it
Index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. but I was avoiding introducing the concept of an Index which would be totally unsafe. The point was that the marker has a scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I still would rename it to
Index
. But makeendIndex
a private property (and add a comment why it's unsafe when used directly).