Skip to content

Move-only check the value projected from addressors. #70475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

jckarter
Copy link
Contributor

Mark the result of a move-only addressor as unresolved. The pointed-at value cannot be consumed so ensure that only [read] or [modify] accesses are performed. Update the move-only checker to recognize code patterns from addressors.

@jckarter jckarter requested a review from gottesmm December 14, 2023 23:23
@jckarter jckarter force-pushed the noncopyable-addressors branch from 7b52c53 to b2a5b34 Compare December 15, 2023 00:37
@jckarter
Copy link
Contributor Author

@swift-ci Please test

Mark the result of a move-only addressor as unresolved. The pointed-at value
cannot be consumed so ensure that only [read] or [modify] accesses are
performed. Update the move-only checker to recognize code patterns
from addressors.
@jckarter jckarter force-pushed the noncopyable-addressors branch from b2a5b34 to 1b9a071 Compare December 15, 2023 18:10
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter
Copy link
Contributor Author

@swift-ci Please test Linux

@jckarter jckarter merged commit 58bf935 into swiftlang:main Dec 15, 2023
@hyp
Copy link
Contributor

hyp commented Dec 15, 2023

Yay! thank you

drodriguez added a commit to drodriguez/swift that referenced this pull request Dec 17, 2023
… feature

moveonly_addressors.swift (added in swiftlang#70475) uses the experimental
feature `NonescapableTypes`, which requires an asserts compiler to work,
so requires marking the test as `REQUIRES: asserts`.
drodriguez added a commit that referenced this pull request Dec 17, 2023
… feature (#70517)

moveonly_addressors.swift (added in #70475) uses the experimental
feature `NonescapableTypes`, which requires an asserts compiler to work,
so requires marking the test as `REQUIRES: asserts`.
Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

meg-gupta pushed a commit to meg-gupta/swift that referenced this pull request Dec 21, 2023
… feature (swiftlang#70517)

moveonly_addressors.swift (added in swiftlang#70475) uses the experimental
feature `NonescapableTypes`, which requires an asserts compiler to work,
so requires marking the test as `REQUIRES: asserts`.
Catfish-Man pushed a commit to Catfish-Man/swift that referenced this pull request Jan 19, 2024
… feature (swiftlang#70517)

moveonly_addressors.swift (added in swiftlang#70475) uses the experimental
feature `NonescapableTypes`, which requires an asserts compiler to work,
so requires marking the test as `REQUIRES: asserts`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants