-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Move-only check the value projected from addressors. #70475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b52c53
to
b2a5b34
Compare
@swift-ci Please test |
Mark the result of a move-only addressor as unresolved. The pointed-at value cannot be consumed so ensure that only [read] or [modify] accesses are performed. Update the move-only checker to recognize code patterns from addressors.
b2a5b34
to
1b9a071
Compare
@swift-ci Please test |
@swift-ci Please test Linux |
Yay! thank you |
drodriguez
added a commit
to drodriguez/swift
that referenced
this pull request
Dec 17, 2023
… feature moveonly_addressors.swift (added in swiftlang#70475) uses the experimental feature `NonescapableTypes`, which requires an asserts compiler to work, so requires marking the test as `REQUIRES: asserts`.
gottesmm
reviewed
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Dec 21, 2023
… feature (swiftlang#70517) moveonly_addressors.swift (added in swiftlang#70475) uses the experimental feature `NonescapableTypes`, which requires an asserts compiler to work, so requires marking the test as `REQUIRES: asserts`.
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
… feature (swiftlang#70517) moveonly_addressors.swift (added in swiftlang#70475) uses the experimental feature `NonescapableTypes`, which requires an asserts compiler to work, so requires marking the test as `REQUIRES: asserts`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the result of a move-only addressor as unresolved. The pointed-at value cannot be consumed so ensure that only [read] or [modify] accesses are performed. Update the move-only checker to recognize code patterns from addressors.