Skip to content

Use OSSALifetimeCompletion in PredictableMemOpt #70477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2023
Merged

Use OSSALifetimeCompletion in PredictableMemOpt #70477

merged 1 commit into from
Dec 16, 2023

Conversation

meg-gupta
Copy link
Contributor

The current algorithm to complete lifetimes is incorrect in a few cases. Use OSSALifetimeCompletion instead.

Fixes rdar://119204768

@meg-gupta meg-gupta requested a review from atrick December 14, 2023 23:55
@meg-gupta meg-gupta requested a review from eeckstein as a code owner December 14, 2023 23:55
eeckstein
eeckstein approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

atrick
atrick approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test

@meg-gupta meg-gupta enabled auto-merge December 15, 2023 19:26
@meg-gupta
Use OSSALifetimeCompletion in PredictableMemOpt
06f0d15 
The current algorithm to complete lifetimes is incorrect in a few cases.
Use OSSALifetimeCompletion instead.

Fixes rdar://119204768
@meg-gupta
Copy link
Contributor Author

@swift-ci smoke test

@meg-gupta meg-gupta merged commit 890ec7d into swiftlang:main Dec 16, 2023
@vanvoorden
Copy link
Contributor

https://forums.swift.org/t/non-deterministic-5-10-compiler-failures-from-predictablememoryaccessoptimizations-and-swift-5-10/72630

@meg-gupta By any chance was this a fix for what looks like some non-deterministic crashes from 5.10?

@meg-gupta
Copy link
Contributor Author

@vanvoorden This PR fixed an issue that would have been raised by ownership verification. It looks like your crash is somewhere in the type system. Will be helpful if you can provide a reproducer for the issue you are seeing.

@vanvoorden
Copy link
Contributor

It looks like your crash is somewhere in the type system.

@meg-gupta Hmm… looks like #71241 and #71730 landed in 6.0… would that look related to what I am seeing in 5.10?

Will be helpful if you can provide a reproducer for the issue you are seeing.

I don't have a clean repro yet… sorry about that. I can keep trying to see if I can find something that crashes consistently in a new package.

@vanvoorden
Copy link
Contributor

@meg-gupta I think I might have found a repro. #74609. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrick atrick atrick approved these changes

@eeckstein eeckstein eeckstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meg-gupta @vanvoorden @atrick @eeckstein