[CMake] Add dep in add_swift_target_library_single from install component #70490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nent While `add_swift_target_library` has code to add a dependency from the install component to the target, similar code was missing from `add_swift_target_library_single`, probably because `add_swift_target_library` calls `add_swift_target_library_single`, so the extra dependency is not necessary. However, there's usages of `add_swift_target_library_single` outside `add_swift_target_library` which were creating targets that were not dependencies of their install components. Some of those cases are the embedded stdlib targets, which are installed as part of the `stdlib` component. It normally does not matter when using `build-script`, because those targets are build as part of `all`, but it does matter if one is using CMake/Ninja directly or in cases where `build-script` is not used. Trying to use targets like `install-stdlib` will had missed building the embedded stdlib, and failed the installation.
|
@swift-ci please test |
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Dec 21, 2023
…nent (swiftlang#70490) While `add_swift_target_library` has code to add a dependency from the install component to the target, similar code was missing from `add_swift_target_library_single`, probably because `add_swift_target_library` calls `add_swift_target_library_single`, so the extra dependency is not necessary. However, there's usages of `add_swift_target_library_single` outside `add_swift_target_library` which were creating targets that were not dependencies of their install components. Some of those cases are the embedded stdlib targets, which are installed as part of the `stdlib` component. It normally does not matter when using `build-script`, because those targets are build as part of `all`, but it does matter if one is using CMake/Ninja directly or in cases where `build-script` is not used. Trying to use targets like `install-stdlib` will had missed building the embedded stdlib, and failed the installation.
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
…nent (swiftlang#70490) While `add_swift_target_library` has code to add a dependency from the install component to the target, similar code was missing from `add_swift_target_library_single`, probably because `add_swift_target_library` calls `add_swift_target_library_single`, so the extra dependency is not necessary. However, there's usages of `add_swift_target_library_single` outside `add_swift_target_library` which were creating targets that were not dependencies of their install components. Some of those cases are the embedded stdlib targets, which are installed as part of the `stdlib` component. It normally does not matter when using `build-script`, because those targets are build as part of `all`, but it does matter if one is using CMake/Ninja directly or in cases where `build-script` is not used. Trying to use targets like `install-stdlib` will had missed building the embedded stdlib, and failed the installation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
add_swift_target_libraryhas code to add a dependency from the install component to the target, similar code was missing fromadd_swift_target_library_single, probably becauseadd_swift_target_librarycallsadd_swift_target_library_single, so the extra dependency is not necessary.However, there's usages of
add_swift_target_library_singleoutsideadd_swift_target_librarywhich were creating targets that were not dependencies of their install components. Some of those cases are the embedded stdlib targets, which are installed as part of thestdlibcomponent.It normally does not matter when using
build-script, because those targets are build as part ofall, but it does matter if one is using CMake/Ninja directly or in cases wherebuild-scriptis not used. Trying to use targets likeinstall-stdlibwill had missed building the embedded stdlib, and failed the installation.