[test] Mark some tests as requiring Swift Syntax #70493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodriguez
requested review from
ahoppen,
bnbarham,
hamishknight,
rintaro and
CodaFi
as code owners
|
@swift-ci please test |
Some of the tests now depend on features provided by Swift Syntax, and will fail to pass if building without Swift Syntax support. This commits marks all the tests I know fail to pass when Swift Syntax is disabled. - swiftlang#70281 modified `ASTGen/verify-parse.swift` - swiftlang#70287 created `refactoring/SyntacticRename/operator.swift` and `SourceKit/RelatedIdents/operator.swift` - swiftlang#70389 modified `SourceKit/Refactoring/basic.swift` and indirectly modified all `refactoring/ExtractFunction/*` tests.
drodriguez
force-pushed
the
requires-swift-syntax-tests
branch
from
fdcdb42 to
618a77d
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Dec 15, 2023
|
@drodriguez, the community Android CI appears to be stuck, maybe it needs to be reset? |
|
@shahmishal: the jobs in the community CI does not have some timeout to kill runaway tests? It might not be bad to add something like 6 hours or similar to those jobs. |
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Dec 21, 2023
Some of the tests now depend on features provided by Swift Syntax, and will fail to pass if building without Swift Syntax support. This commits marks all the tests I know fail to pass when Swift Syntax is disabled. - swiftlang#70281 modified `ASTGen/verify-parse.swift` - swiftlang#70287 created `refactoring/SyntacticRename/operator.swift` and `SourceKit/RelatedIdents/operator.swift` - swiftlang#70389 modified `SourceKit/Refactoring/basic.swift` and indirectly modified all `refactoring/ExtractFunction/*` tests.
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
Some of the tests now depend on features provided by Swift Syntax, and will fail to pass if building without Swift Syntax support. This commits marks all the tests I know fail to pass when Swift Syntax is disabled. - swiftlang#70281 modified `ASTGen/verify-parse.swift` - swiftlang#70287 created `refactoring/SyntacticRename/operator.swift` and `SourceKit/RelatedIdents/operator.swift` - swiftlang#70389 modified `SourceKit/Refactoring/basic.swift` and indirectly modified all `refactoring/ExtractFunction/*` tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests now depend on features provided by Swift Syntax, and will fail to pass if building without Swift Syntax support.
This commit marks all the tests I know fail to pass when Swift Syntax is disabled.
ASTGen/verify-parse.swiftrefactoring/SyntacticRename/operator.swiftandSourceKit/RelatedIdents/operator.swiftNameMatcher#70389 modifiedSourceKit/Refactoring/basic.swiftand indirectly modified allrefactoring/ExtractFunction/*tests.