Add some instruction simplifications #70494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace
```
%1 = enum $E, #someCase, %payload
switch_enum %1, case #someCase: bb1, ...
bb1(%payloadArgument):
```
->
```
br bb1(%payload)
bb1(%payloadArgument):
```
…string literals A pointer to a string literal is never null
Check that `StaticString("some string literal").utf8Start` can be put into a statically initialized global
|
@swift-ci test |
|
@swift-ci benchmark |
kubamracek
approved these changes
Dec 15, 2023
finagolfin
reviewed
Dec 19, 2023
| @@ -38,8 +38,14 @@ struct MyStruct5 { | |||
| } | |||
| @_section("__TEXT,__mysection") var g_MyStruct5: MyStruct5 = MyStruct5(q: MyStruct4(a: 42, s: MyStruct1(a: 43, b: 44)), r: MyStruct4(a: 42, s: MyStruct1(a: 43, b: 44))) | |||
|
|
|||
| @_section("__TEXT,__mysection") let utf8OfStaticString = StaticString("hello").utf8Start | |||
There was a problem hiding this comment.
@eeckstein, strangely this broke on the 32-bit Android armv7 CI but not on the aarch64 CI:
/home/ubuntu/jenkins/workspace/oss-swift-RA-linux-ubuntu-16.04-android/swift/test/IRGen/section_structs.swift:41:37: error: global variable must be a compile-time constant to use @_section attribute
@_section("__TEXT,__mysection") let utf8OfStaticString = StaticString("hello").utf8Start
^
This compiler on the Android CI is built with a full bootstrap on linux, as that CI has no prebuilt Swift compiler installed, so the swift-syntax parser is not built. Maybe that has something to do with it, but weird that it only hits for 32-bit compilation.
There was a problem hiding this comment.
@finagolfin do you have any error log or a link to the ci failure?
There was a problem hiding this comment.
There was a problem hiding this comment.
Let's disable the test for 32-bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enum-switch_enumpairsThis enables to put
StaticString("some string literal").utf8Startinto a statically initialized global