build: add support for testing more of the compilers on Windows #70497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to conditionally run the test suite for LLVM, LLD, LLDB, Clang, and Swift. This will allow us to increase the test coverage in CI to avoid regressions.
|
CC: @tristanlabelle |
|
@swift-ci please test |
|
CC: @shahmishal |
tristanlabelle
approved these changes
Dec 15, 2023
| "-TestLLVM" = $Test -contains "llvm"; | ||
| "-TestSwift" = $Test -contains "swift"; | ||
| } | ||
| Build-Compilers $HostArch @Tests |
There was a problem hiding this comment.
You could avoid splatting by using -TestClang:($Test -contains "clang") (-Foo:$true / -Foo:$false is valid syntax)
There was a problem hiding this comment.
Yeah, that is certainly a viable option as well. I find it difficult to tell which is better. The collection as is does make it easier to tell at a glance what options are being setup. I would defer to your expertise if one is better than the other.
There was a problem hiding this comment.
I'm going to merge this for now, but happy to revisit if you have suggestions here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to conditionally run the test suite for LLVM, LLD, LLDB, Clang, and Swift. This will allow us to increase the test coverage in CI to avoid regressions.