Skip to content

[Sanitizers] Add new sanitize-stable-abi flag for libsanitizers. #70508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

wrotki
Copy link
Contributor

@wrotki wrotki commented Dec 16, 2023

This patch adds a new flag sanitize-stable-abi to support linking against the Sanitizers stable ABI added recently in compiler-rt. The patch also passes extra options for the ASan pass when using this flag to outline instrumentation code and remove version check.

NOTE: this was #69943 , but Usama is out till after the new year break, so I need to take over and apply feedback from there

rdar://112915278

@wrotki
Copy link
Contributor Author

wrotki commented Dec 16, 2023

@swift-ci test

@wrotki wrotki removed the request for review from artemcm December 16, 2023 01:12
@wrotki
Copy link
Contributor Author

wrotki commented Dec 16, 2023

@swift-ci Please smoke test

@wrotki wrotki requested a review from artemcm December 16, 2023 01:25
This patch adds a new flag sanitize-stable-abi to support linking
against the Sanitizers stable ABI added recently in compiler-rt. The
patch also passes extra options for the ASan pass when using this flag
to outline instrumentation code and remove version check.

rdar://112915278
@wrotki wrotki force-pushed the eng/m_borsa/112915278 branch from 4872565 to 3053fe0 Compare December 16, 2023 22:13
@wrotki
Copy link
Contributor Author

wrotki commented Dec 16, 2023

@swift-ci Please smoke test

@wrotki
Copy link
Contributor Author

wrotki commented Dec 17, 2023

@swift-ci Please test Windows platform

@wrotki wrotki requested review from artemcm and removed request for artemcm December 17, 2023 21:57
@wrotki wrotki merged commit 5f43205 into main Dec 18, 2023
@wrotki wrotki deleted the eng/m_borsa/112915278 branch December 18, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants