Skip to content

Don't use opaque parameters in the standard library #70520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DougGregor
Copy link
Member

The SIL printer is printing opaque parameters as , which breaks the SIL parser. Stop using opaque parameters in the standard library for the moment to unbreak SIL parsing of the standard library.

The SIL printer is printing opaque parameters as <anonymous>, which
breaks the SIL parser. Stop using opaque parameters in the standard
library for the moment to unbreak SIL parsing of the standard library.
@DougGregor DougGregor requested a review from a team as a code owner December 18, 2023 18:16
@DougGregor
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sad, though.

@DougGregor
Copy link
Member Author

This is sad, though.

Indeed! I doubt it's that hard to fix in the SIL printer.

@DougGregor DougGregor merged commit 82ebc54 into swiftlang:main Dec 18, 2023
@DougGregor DougGregor deleted the no-opaque-parameters-in-stdlib branch December 18, 2023 18:33
@slavapestov
Copy link
Contributor

Good news, friends. I have fixed the SIL printer: #70667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants