[Test] Fix the wrong subsitution of swift-frontend-target in tests
#70530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
compnerd,
rintaro,
mikeash and
DougGregor
|
@swift-ci please smoke test |
There is no `%swift-frontend-target` subsitution in test, which is actually `%target-swift-frontend`. The wrong spelling is actually interpreted by lit as `%swift`-frontend-target, and surprising didn't break any tests as the last argument from subsitution is `-define-availability` so it just leads to an very akward availability definition.
cachemeifyoucan
force-pushed
the
eng/PR-no-swift-target-frontend
branch
from
89b33c4 to
407674e
Compare
|
@swift-ci please smoke test |
|
That's a hilarious bug. |
mikeash
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no
%swift-frontend-targetsubsitution in test, which is actually%target-swift-frontend. The wrong spelling is actually interpruted by lit as%swift-frontend-target, and surprising didn't break any tests as the last argument from subsitution is-define-availabilityso it just leads to an very akward availability definition.