Skip to content

[test] Make BlocksRuntimeStubs use never_install component. #70545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2023
Merged

[test] Make BlocksRuntimeStubs use never_install component. #70545

merged 1 commit into from
Dec 20, 2023

Conversation

drodriguez
Copy link
Contributor

For some reason, 4 years ago, in ea90256 I added this target to dev, which does not make sense because these stubs are only intended for testing. Make them never_install to avoid distributing them when doing install-dev.

@drodriguez
[test] Make BlocksRuntimeStubs use never_install component.
19d4750 
For some reason, 4 years ago, in ea90256 I added this target to `dev`,
which does not make sense because these stubs are only intended for
testing. Make them `never_install` to avoid distributing them when doing
`install-dev`.
@drodriguez drodriguez requested a review from a team as a code owner December 19, 2023 20:23
@drodriguez
Copy link
Contributor Author

@swift-ci please test

@drodriguez drodriguez enabled auto-merge (squash) December 19, 2023 20:27
@drodriguez drodriguez merged commit e2d4208 into swiftlang:main Dec 20, 2023
@drodriguez drodriguez deleted the blocks-runtime-stub-install-component branch December 20, 2023 07:28
meg-gupta pushed a commit to meg-gupta/swift that referenced this pull request Dec 21, 2023
@drodriguez @meg-gupta
[test] Make BlocksRuntimeStubs use never_install component. (swiftlan…
40f4d11 
…g#70545)

For some reason, 4 years ago, in ea90256 I added this target to `dev`,
which does not make sense because these stubs are only intended for
testing. Make them `never_install` to avoid distributing them when doing
`install-dev`.
Catfish-Man pushed a commit to Catfish-Man/swift that referenced this pull request Jan 19, 2024
@drodriguez @Catfish-Man
[test] Make BlocksRuntimeStubs use never_install component. (swiftlan…
b7fdcd2 
…g#70545)

For some reason, 4 years ago, in ea90256 I added this target to `dev`,
which does not make sense because these stubs are only intended for
testing. Make them `never_install` to avoid distributing them when doing
`install-dev`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glessard glessard glessard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drodriguez @glessard