[5.10🍒] autoreleasing isolated foreign errors #70546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@autoreleasing
value returned from an async function is not being retained prior to changing executors/actors, only afterwards. If the caller and callee have different actors, then an executor hop will happen, which triggers the autorelease pool and thus destroying the returned value. Upon returning from the hop, we will attempt to retain the destroyed value and trigger a use-after-free / crash in the runtime due to incrementing a ref count of a destroyed object. Here's a visual of the change:end_borrow
that normally is right after the hop now comes before it), though in most cases it should lead to no changes in the final assembly.Reviewed By: @gottesmm